Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): stop TFC plans when we discard / stop / ctrl-c #1650

Merged
merged 12 commits into from
Mar 25, 2022

Conversation

DanielMSchmidt
Copy link
Contributor

This PR makes sure we clean up what we leave behind in TFC when we run apply / destroy.

Closes #1607 and #482

packages/cdktf-cli/lib/models/terraform-cli.ts Outdated Show resolved Hide resolved
packages/cdktf-cli/lib/models/terraform-cloud.ts Outdated Show resolved Hide resolved
packages/cdktf-cli/lib/models/terraform-cloud.ts Outdated Show resolved Hide resolved
packages/cdktf-cli/lib/stack-execution.ts Outdated Show resolved Hide resolved
DanielMSchmidt and others added 7 commits March 25, 2022 00:29
We always need to fetch all, but we don't want to reprint it
as we deprecate resource parsing we don't necessarily need this anymore
Co-authored-by: Ansgar Mertens <ansgar@hashicorp.com>
Co-authored-by: Ansgar Mertens <ansgar@hashicorp.com>
Copy link
Member

@ansgarm ansgarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Abort Terraform Cloud runs on ctr-c
2 participants