Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lib): add docstrings to S3 backend resource #1780

Merged
merged 3 commits into from May 6, 2022

Conversation

aayushharwani-aidash
Copy link
Contributor

Have added doc-string to s3 backend.
Working on issue -#1268

@hashicorp-cla
Copy link

hashicorp-cla commented May 6, 2022

CLA assistant check
All committers have signed the CLA.

@aayushharwani-aidash aayushharwani-aidash changed the title added-docs-s3-backend fix:added-docs-s3-backend May 6, 2022
@ansgarm ansgarm changed the title fix:added-docs-s3-backend feat(cdktf): add docstrings to S3 backend resource May 6, 2022
@ansgarm
Copy link
Member

ansgarm commented May 6, 2022

Hi @aayushharwani-aidash 👋
Thank you for the PR 👍 Looking good.

fyi: I adjusted the title of the PR to satisfy our linting rules for PRs.

Also, for PRs with a single commit, that rule also applies to the commit message, so you'd have to adjust it – or I can take care of that, if you want 😇

@aayushharwani-aidash
Copy link
Contributor Author

Hi @aayushharwani-aidash 👋 Thank you for the PR 👍 Looking good.

fyi: I adjusted the title of the PR to satisfy our linting rules for PRs.

Also, for PRs with a single commit, that rule also applies to the commit message, so you'd have to adjust it – or I can take care of that, if you want 😇

can you help me in doing it ?

@ansgarm ansgarm changed the title feat(cdktf): add docstrings to S3 backend resource feat(lib): add docstrings to S3 backend resource May 6, 2022
@ansgarm
Copy link
Member

ansgarm commented May 6, 2022

Hi @aayushharwani-aidash 👋 Thank you for the PR 👍 Looking good.
fyi: I adjusted the title of the PR to satisfy our linting rules for PRs.
Also, for PRs with a single commit, that rule also applies to the commit message, so you'd have to adjust it – or I can take care of that, if you want 😇

can you help me in doing it ?

If you want to do it yourself and are using Git locally on the CLI, you can run:

git commit --amend

and then edit the message and afterwards run

git push --force

to push that changed commit to this PR.

If I should do that for you, just tell me. Happy to do that for you, if you want.

@aayushharwani-aidash
Copy link
Contributor Author

Hi @aayushharwani-aidash 👋 Thank you for the PR 👍 Looking good.
fyi: I adjusted the title of the PR to satisfy our linting rules for PRs.
Also, for PRs with a single commit, that rule also applies to the commit message, so you'd have to adjust it – or I can take care of that, if you want 😇

can you help me in doing it ?

If you want to do it yourself and are using Git locally on the CLI, you can run:

git commit --amend

and then edit the message and afterwards run

git push --force

to push that changed commit to this PR.

If I should do that for you, just tell me. Happy to do that for you, if you want.

Will give a try.

@aayushharwani-aidash
Copy link
Contributor Author

@ansgarm have made changes, as suggested by you

@ansgarm ansgarm merged commit a3338f4 into hashicorp:main May 6, 2022
@ansgarm
Copy link
Member

ansgarm commented May 6, 2022

Thanks again for your contribution @aayushharwani-aidash 👍

@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants