Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(provider-generator): Move generated files into their own directories #2153

Merged
merged 5 commits into from
Oct 3, 2022

Conversation

ansgarm
Copy link
Member

@ansgarm ansgarm commented Sep 30, 2022

Closes #2147

Todos

  • Put generated code into sub-directory
  • Update tests
  • Add Markdown file to newly generated directory with link to Terraform Registry
  • Add new test to test Markdown file existence & content (if not already part of other snapshots)

Copy link
Contributor

@mutahhir mutahhir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, good to go! Just one question in general about joining paths using path.join instead of templated strings.

@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add docs to new resource namespaces
2 participants