fix: Graceful failures when using cdktf with non-admin tokens
#2258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutahhir
requested review from
ansgarm and
Maed223
and removed request for
a team
mutahhir
requested review from
DanielMSchmidt and
a team
and removed request for
DanielMSchmidt
mutahhir
force-pushed
the
chore/optional-json-output
branch
from
1aa71fc
to
c671f81
Compare
DanielMSchmidt
approved these changes
Nov 14, 2022
mutahhir
force-pushed
the
chore/optional-json-output
branch
from
857f0d4
to
22a2c0f
Compare
mutahhir
force-pushed
the
chore/optional-json-output
branch
from
22a2c0f
to
a3160bc
Compare
…in outputs when token lacks permissions
mutahhir
force-pushed
the
chore/optional-json-output
branch
from
1fe2c27
to
e7860c5
Compare
Merged
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2236
I'm still not really comfortable with the big-picture understanding of how we use
json-output. While this PR works well enough, please let me know if there are certain scenarios that are broken because of this. Especially around cross-stack references and so on.