Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): translate aspects example to c# #2273

Merged
merged 2 commits into from
Nov 23, 2022
Merged

chore(docs): translate aspects example to c# #2273

merged 2 commits into from
Nov 23, 2022

Conversation

DanielMSchmidt
Copy link
Contributor

@DanielMSchmidt DanielMSchmidt commented Nov 11, 2022 •
edited by xiehan

re: #1929

@DanielMSchmidt DanielMSchmidt changed the title translate csharp aspects chore(docs): translate aspects example to c# Nov 11, 2022
@DanielMSchmidt DanielMSchmidt changed the base branch from main to refactor-csharp-documentation-example November 11, 2022 16:04
@DanielMSchmidt DanielMSchmidt marked this pull request as ready for review November 11, 2022 16:04
@DanielMSchmidt DanielMSchmidt requested review from ansgarm and Maed223 and removed request for a team November 11, 2022 16:04
@DanielMSchmidt DanielMSchmidt force-pushed the refactor-csharp-documentation-example branch 2 times, most recently from b14af26 to 614fc97 Compare November 14, 2022 09:33
Base automatically changed from refactor-csharp-documentation-example to main November 17, 2022 11:37
mutahhir
mutahhir approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@mutahhir mutahhir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DanielMSchmidt DanielMSchmidt merged commit 7388f7d into main Nov 23, 2022
@DanielMSchmidt DanielMSchmidt deleted the translate-csharp-aspects branch November 23, 2022 11:16
jsteinich
jsteinich reviewed Nov 25, 2022
View reviewed changes
examples/csharp/documentation/MyTerraformStack.csproj
@@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>netcoreapp3.1</TargetFramework>
<TargetFramework>netcoreapp5.0</TargetFramework>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.net 5 is unsupported. Would be better to net6.

@DanielMSchmidt DanielMSchmidt mentioned this pull request Dec 5, 2022
Merged
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsteinich jsteinich jsteinich left review comments

@mutahhir mutahhir mutahhir approved these changes

@laurapacilio laurapacilio Awaiting requested review from laurapacilio

@mgarrell777 mgarrell777 Awaiting requested review from mgarrell777

@ansgarm ansgarm Awaiting requested review from ansgarm ansgarm is a code owner automatically assigned from hashicorp/cdktf

@Maed223 Maed223 Awaiting requested review from Maed223 Maed223 is a code owner automatically assigned from hashicorp/cdktf

Assignees
No one assigned
Labels
size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DanielMSchmidt @mutahhir @jsteinich