-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): abort apply if not all variables are known #2455
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
b1ae774
to
d8134ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!! 🥇
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This PR both adds support for missing variables (by throwing an explicit error when terraform encounters the variable).
It also deals with errors not bubbling up to the terminal, leading in errors not setting the exit status to 1. I added some comments for better context.
Closes #2425