feat: use our own pre-built package for node-pty to have builds for Nodejs 19 available #2478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansgarm
requested review from
mutahhir and
DanielMSchmidt
and removed request for
a team
DanielMSchmidt
approved these changes
Jan 12, 2023
ansgarm
force-pushed
the
use-our-prebuild-package
branch
from
4851c66
to
297c674
Compare
ansgarm
force-pushed
the
use-our-prebuild-package
branch
from
927ff08
to
940eb48
Compare
ansgarm
force-pushed
the
use-our-prebuild-package
branch
from
940eb48
to
613a638
Compare
ansgarm
force-pushed
the
use-our-prebuild-package
branch
from
613a638
to
6de3682
Compare
…odejs 19 available
We commonly see errors in CI stating that inNewWorkingDirectory is not a function. This can happen if the beforeAll hook takes to long, as apparently jest doesn't properly stop all tests if a hook does not finish in time
ansgarm
force-pushed
the
use-our-prebuild-package
branch
from
6de3682
to
5fd92ec
Compare
Merged
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2441