Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use correctly named syntax in comments #2562

Merged
merged 1 commit into from
Jan 31, 2023
Merged

fix: use correctly named syntax in comments #2562

merged 1 commit into from
Jan 31, 2023

Conversation

DanielMSchmidt
Copy link
Contributor

No description provided.

@DanielMSchmidt DanielMSchmidt requested a review from a team as a code owner January 31, 2023 17:02
@DanielMSchmidt DanielMSchmidt requested review from mutahhir and Maed223 and removed request for a team January 31, 2023 17:02
ansgarm
ansgarm approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@ansgarm ansgarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Not blocking on this, but is there a way to reuse that same initialization that is now copied into multiple places?

@DanielMSchmidt
Copy link
Contributor Author

No idea, I'm not a C# expert. Maybe a method?

@DanielMSchmidt DanielMSchmidt merged commit 12d04eb into main Jan 31, 2023
@DanielMSchmidt DanielMSchmidt deleted the fix-csharp-testing-instructions branch January 31, 2023 18:55
@ansgarm ansgarm mentioned this pull request Feb 6, 2023
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ansgarm ansgarm ansgarm approved these changes

@mutahhir mutahhir Awaiting requested review from mutahhir mutahhir is a code owner automatically assigned from hashicorp/cdktf

@Maed223 Maed223 Awaiting requested review from Maed223 Maed223 is a code owner automatically assigned from hashicorp/cdktf

Assignees
No one assigned
Labels
ci/run-unit/cdktf-cli size/s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DanielMSchmidt @ansgarm @team-tf-cdk