Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): camel -> snake case in resource escape hatches #2571

Merged
merged 2 commits into from
Feb 2, 2023

Conversation

Maed223
Copy link
Contributor

@Maed223 Maed223 commented Feb 1, 2023

Closes #2566

Copy link
Member

@ansgarm ansgarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but spotted a separate typo that we can fix while we're at it

examples/python/documentation/resources.py Outdated Show resolved Hide resolved
examples/python/documentation/resources.py Outdated Show resolved Hide resolved
website/docs/cdktf/concepts/resources.mdx Outdated Show resolved Hide resolved
website/docs/cdktf/concepts/resources.mdx Outdated Show resolved Hide resolved
@ansgarm ansgarm force-pushed the fix-resource-override-properties branch from 940e8d3 to aaf5cd7 Compare February 2, 2023 11:35
@ansgarm
Copy link
Member

ansgarm commented Feb 2, 2023

I just went ahead and added my suggestions myself 😄
image

@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2023

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

documentation for resources escape hatch uses wrong casing in code snippets
3 participants