feat(lib): Support adding Validations on App #2591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansgarm
requested review from
mutahhir and
Maed223
and removed request for
a team
DanielMSchmidt
approved these changes
Feb 2, 2023
Validations are a feature of the constructs lib. Previously we only ran validations added to Stacks (and below). This change also runs them on the root App This is in preparation for adding a validation that confirms that no stacks are reusing the same backend configuration
ansgarm
force-pushed
the
app-level-validations
branch
from
cc2e538
to
7d03306
Compare
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validations are a feature of the constructs lib. Previously we only ran validations added to Stacks (and below). This change also runs them on the root App
This is in preparation for adding a validation that confirms that no stacks are reusing the same backend configuration