Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hcl2cdk): support resource metadata #2745

Merged
merged 13 commits into from
Mar 30, 2023
Merged

feat(hcl2cdk): support resource metadata #2745

merged 13 commits into from
Mar 30, 2023

Conversation

DanielMSchmidt
Copy link
Contributor

@DanielMSchmidt DanielMSchmidt commented Mar 29, 2023 •
edited

Related issue

Fixes #2642
Closes #2728

Description

Terraform resource metadata should be converted using the specific classes / properties instead of overrides.
This PR also adds library classes for pre and post conditions

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

ansgarm
ansgarm reviewed Mar 29, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@DanielMSchmidt DanielMSchmidt force-pushed the support-terraform-meta-properties branch from 021d47b to 2e2ab8f Compare March 29, 2023 12:05
@DanielMSchmidt DanielMSchmidt force-pushed the support-terraform-meta-properties branch 2 times, most recently from 55d3df2 to 4b93472 Compare March 29, 2023 12:07
@DanielMSchmidt DanielMSchmidt marked this pull request as ready for review March 29, 2023 14:09
@DanielMSchmidt DanielMSchmidt requested review from mutahhir and Maed223 and removed request for a team March 29, 2023 14:09
ansgarm
ansgarm approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@ansgarm ansgarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to disregard my nit, if you feel strongly about it, but I'd prefer us to either use Postcondition / postcondition or PostCondition / postCondition 😇

packages/@cdktf/hcl2cdk/test/__snapshots__/resource-meta-properties.test.ts.snap Show resolved Hide resolved
packages/cdktf/lib/terraform-conditions.ts Outdated Show resolved Hide resolved
packages/cdktf/lib/terraform-variable.ts Show resolved Hide resolved
@DanielMSchmidt DanielMSchmidt force-pushed the support-terraform-meta-properties branch from 072ca6f to 305d181 Compare March 30, 2023 08:27
@DanielMSchmidt DanielMSchmidt force-pushed the support-terraform-meta-properties branch from 305d181 to 66a6978 Compare March 30, 2023 12:36
@DanielMSchmidt DanielMSchmidt merged commit ff98f40 into main Mar 30, 2023
@DanielMSchmidt DanielMSchmidt deleted the support-terraform-meta-properties branch March 30, 2023 14:45
@mutahhir mutahhir mentioned this pull request Apr 18, 2023
Merged
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ansgarm ansgarm ansgarm approved these changes

@robin-norwood robin-norwood Awaiting requested review from robin-norwood

@mutahhir mutahhir Awaiting requested review from mutahhir mutahhir is a code owner automatically assigned from hashicorp/cdktf

@Maed223 Maed223 Awaiting requested review from Maed223 Maed223 is a code owner automatically assigned from hashicorp/cdktf

Assignees
No one assigned
Labels
ci/run-unit/@cdktf/hcl2cdk ci/run-unit/cdktf size/l
Projects
None yet
Milestone
No milestone
3 participants
@DanielMSchmidt @ansgarm @team-tf-cdk