chore: Enable type coercion again

[mutahhir]

Related issue

Fixes #

Description

In plain English, describe your approach to addressing the issue linked above. For example, if you made a particular design decision, let us know why you chose this path instead of another solution.

Checklist

• I have updated the PR title to match CDKTF's style guide
• I have run the linter on my code locally
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation if applicable
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works if applicable
• New and existing unit tests pass locally with my changes

[mutahhir]

These get removed in the iterators PR I believe.

[mutahhir]

This function is moved from generation.ts

[mutahhir]

This function is mostly a copy of the generation.ts one, but doesn't use references, and does more smart things :D

[ansgarm]

It is also possible that e.g. the second parameter of two is variadic (e.g. cidrsubnets) – which would not be caught by this.

An alternative would be to remove this map and extend the one below to handle the (if any) variadic parameter. I did this in my prototyped code here:

terraform-cdk/packages/@cdktf/hcl2cdk/lib/__tests__/functions.test.ts

Lines 692 to 717 in 7793f56

	const args: t.Expression[] = [];
	mapping.parameters.forEach((param, idx) => {
	if (param.variadic) {
	// return an array with all remaining children (each mapped accordingly)
	args.push(
	t.arrayExpression(
	tfAst.children
	.slice(idx)
	.map((child) => terraformThingToTs(child, param.type))
	)
	);
	} else {
	const child = tfAst.children[idx];
	if (child) {
	args.push(terraformThingToTs(child, param.type));
	} else if (!param.optional) {
	throw new Error(
	`Terraform function call to "${name}" is not valid! Parameter at index ${idx} of type ${
	param.type
	} is not optional but received no value. The following parameters were passed: ${JSON.stringify(
	tfAst.children
	)}`
	);
	}
	}
	});

[mutahhir]

Addressed in: #2833

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.