-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(hcl2cdk): Handle referencing lists, sets and maps better when converting #2775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutahhir
changed the title
fix(hcl2cdk): Numeric accessors should use fqn
fix(hcl2cdk): Handle referencing lists, sets and maps better when converting
Apr 5, 2023
mutahhir
requested review from
ansgarm and
Maed223
and removed request for
a team
April 5, 2023 15:19
8 tasks
mutahhir
force-pushed
the
fix/fqn-access-2
branch
from
April 6, 2023 10:45
f7f5e19
to
c9c30ab
Compare
mutahhir
force-pushed
the
fix/fqn-access-2
branch
from
April 6, 2023 13:36
c9c30ab
to
7f09ff5
Compare
ansgarm
approved these changes
Apr 11, 2023
mutahhir
force-pushed
the
fix/fqn-access-2
branch
from
April 11, 2023 14:49
7a8a99c
to
18fbb61
Compare
mutahhir
force-pushed
the
fix/fqn-access-2
branch
from
April 12, 2023 08:01
18fbb61
to
dc2b59b
Compare
Merged
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Fixes #2649
Description
This fixes the conversion to generate expressions that reference map elements using dot notation or lists using numeric accessors better.
Checklist