Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hcl2cdk): Handle referencing lists, sets and maps better when converting #2775

Merged
merged 9 commits into from
Apr 12, 2023

Conversation

mutahhir
Copy link
Contributor

@mutahhir mutahhir commented Apr 5, 2023

Related issue

Fixes #2649

Description

This fixes the conversion to generate expressions that reference map elements using dot notation or lists using numeric accessors better.

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@mutahhir mutahhir changed the title fix(hcl2cdk): Numeric accessors should use fqn fix(hcl2cdk): Handle referencing lists, sets and maps better when converting Apr 5, 2023
@mutahhir mutahhir marked this pull request as ready for review April 5, 2023 15:19
@mutahhir mutahhir requested a review from a team as a code owner April 5, 2023 15:19
@mutahhir mutahhir requested review from ansgarm and Maed223 and removed request for a team April 5, 2023 15:19
packages/@cdktf/hcl2cdk/lib/expressions.ts Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect generation of Terraform expression with fqn to access property
3 participants