Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(lib): update to JSII 5 #2776

Merged
merged 4 commits into from
Apr 6, 2023
Merged

chore(lib): update to JSII 5 #2776

merged 4 commits into from
Apr 6, 2023

Conversation

DanielMSchmidt
Copy link
Contributor

@DanielMSchmidt DanielMSchmidt commented Apr 5, 2023 •
edited

The snapshot format changed, so there was a lot of partly manual changes. But CI should tell us so please only review the first commit :)

@DanielMSchmidt DanielMSchmidt requested a review from a team as a code owner April 5, 2023 15:54
@DanielMSchmidt DanielMSchmidt requested review from mutahhir and Maed223 and removed request for a team April 5, 2023 15:54
@DanielMSchmidt DanielMSchmidt changed the title jsii 5 chore(lib): update to JSII 5 Apr 5, 2023
@team-tf-cdk
Copy link
Collaborator

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@vercel vercel bot requested a deployment to Preview – terraform-cdk-redirects April 5, 2023 16:49 Abandoned
@team-tf-cdk
Copy link
Collaborator

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@team-tf-cdk
Copy link
Collaborator

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

ansgarm
ansgarm requested changes Apr 6, 2023
View reviewed changes
Copy link
Member

@ansgarm ansgarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Only two simple blockers (two rewritten tests have a tiny oversight that makes them more flaky) – the only reason why I didn't approve 😄

packages/@cdktf/cli-core/package.json Show resolved Hide resolved
packages/@cdktf/hcl2cdk/lib/iteration.ts Show resolved Hide resolved
packages/@cdktf/hcl2json/test/hcl2json.test.ts Outdated Show resolved Hide resolved
packages/@cdktf/hcl2json/test/hcl2json.test.ts Outdated Show resolved Hide resolved
@team-tf-cdk
Copy link
Collaborator

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@team-tf-cdk
Copy link
Collaborator

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@team-tf-cdk
Copy link
Collaborator

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

ansgarm
ansgarm approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@ansgarm ansgarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DanielMSchmidt DanielMSchmidt merged commit 08d61b2 into main Apr 6, 2023
317 of 322 checks passed
@DanielMSchmidt DanielMSchmidt deleted the jsii-5 branch April 6, 2023 11:27
@mutahhir mutahhir mentioned this pull request Apr 18, 2023
Merged
@matt-usurp matt-usurp mentioned this pull request May 6, 2023
Closed
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2023

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ansgarm ansgarm ansgarm approved these changes

@mutahhir mutahhir Awaiting requested review from mutahhir mutahhir is a code owner automatically assigned from hashicorp/cdktf

@Maed223 Maed223 Awaiting requested review from Maed223 Maed223 is a code owner automatically assigned from hashicorp/cdktf

Assignees
No one assigned
Labels
ci/provider-integration ci/run-examples ci/run-integration ci/run-unit/@cdktf/cli-core ci/run-unit/@cdktf/commons ci/run-unit/@cdktf/hcl2cdk ci/run-unit/@cdktf/hcl2json ci/run-unit/@cdktf/provider-generator ci/run-unit/cdktf ci/run-unit/cdktf-cli size/xl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DanielMSchmidt @team-tf-cdk @ansgarm