fix(cli): send terraform output before approval #2790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maybedino
requested review from
mutahhir and
ansgarm
and removed request for
a team
ansgarm
approved these changes
Apr 11, 2023
ansgarm
force-pushed
the
approval-plan-output
branch
from
a1c4cf2
to
2e555f3
Compare
mutahhir
approved these changes
Apr 12, 2023
Currently, the terraform output is send after the approval diaglog. This hides the diff until an option was selected. Sending the output first makes the diff visible before the dialog.
ansgarm
force-pushed
the
approval-plan-output
branch
from
2e555f3
to
48f5b0a
Compare
Merged
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Fixes #2749
Description
Currently, the terraform output is send after the approval dialog. This hides the diff until an option was selected. Sending the output first makes the diff visible before the dialog.
It's a very small change, so no new tests or documentation.
Checklist