Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hcl2cdk): support count using TerraformCount #2796

Merged
merged 5 commits into from
Apr 13, 2023
Merged

feat(hcl2cdk): support count using TerraformCount #2796

merged 5 commits into from
Apr 13, 2023

Conversation

DanielMSchmidt
Copy link
Contributor

@DanielMSchmidt DanielMSchmidt commented Apr 13, 2023 •
edited

Related issue

Fixes #2764

Description

count attributes used overrides in the past, this PR let's them use the new TerraformCount construct

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@DanielMSchmidt DanielMSchmidt requested a review from a team as a code owner April 13, 2023 10:21
@DanielMSchmidt DanielMSchmidt requested review from mutahhir and Maed223 and removed request for a team April 13, 2023 10:21
@team-tf-cdk
Copy link
Collaborator

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@DanielMSchmidt DanielMSchmidt merged commit 9f540ea into main Apr 13, 2023
23 checks passed
@DanielMSchmidt DanielMSchmidt deleted the iterator-support-2-with-count branch April 13, 2023 13:14
@mutahhir mutahhir mentioned this pull request Apr 18, 2023
Merged
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mutahhir mutahhir mutahhir approved these changes

@ansgarm ansgarm ansgarm approved these changes

@Maed223 Maed223 Awaiting requested review from Maed223 Maed223 is a code owner automatically assigned from hashicorp/cdktf

Assignees
No one assigned
Labels
ci/run-unit/@cdktf/hcl2cdk size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Count should be handled with API in convert
4 participants
@DanielMSchmidt @team-tf-cdk @mutahhir @ansgarm