Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use property access when refrencing numeric and map accessors #2801

Merged
merged 12 commits into from
Apr 17, 2023

Conversation

mutahhir
Copy link
Contributor

@mutahhir mutahhir commented Apr 14, 2023

Related issue

Fixes https://github.com/orgs/hashicorp/projects/207/views/12?pane=issue&itemId=25543682

Description

Using String templates instead of propertyAccess causes problems with nesting template strings (which would need more context to solve properly), and also when used within CDKTF functions. This PR moves most template string usage that required use of FQN over to using the CDKTF propertyAccess function.

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@team-tf-cdk team-tf-cdk added size/m and removed size/s labels Apr 14, 2023
@mutahhir mutahhir force-pushed the fix/nested-template-strings branch from ed015ba to bf18865 Compare April 14, 2023 13:51
@mutahhir mutahhir marked this pull request as ready for review April 14, 2023 13:59
@mutahhir mutahhir requested a review from a team as a code owner April 14, 2023 13:59
@mutahhir mutahhir requested review from ansgarm and DanielMSchmidt and removed request for a team April 14, 2023 13:59
Copy link
Member

@ansgarm ansgarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mutahhir mutahhir merged commit a21d328 into main Apr 17, 2023
23 checks passed
@mutahhir mutahhir deleted the fix/nested-template-strings branch April 17, 2023 09:22
@mutahhir mutahhir mentioned this pull request Apr 18, 2023
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants