-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: type coercion on primitive values #2805
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutahhir
requested review from
DanielMSchmidt and
Maed223
and removed request for
a team
April 14, 2023 15:04
DanielMSchmidt
approved these changes
Apr 14, 2023
mutahhir
force-pushed
the
fix/primitive-coercion
branch
from
April 14, 2023 15:40
9d194b9
to
8eaf642
Compare
mutahhir
force-pushed
the
fix/primitive-coercion
branch
from
April 17, 2023 08:14
8d15b88
to
ccf418b
Compare
Merged
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Fixes https://github.com/orgs/hashicorp/projects/207/views/12?pane=issue&itemId=25542592
Description
We were only passing string literals through the expression parsing, which was the section of the code that was also doing type coercion. With this change, we now also parse numeric and boolean literals through the same process as string literals
Checklist