Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Accept nested quotes within strings #2813

Merged
merged 3 commits into from
Apr 18, 2023
Merged

Conversation

mutahhir
Copy link
Contributor

Related issue

Fixes https://github.com/orgs/hashicorp/projects/207/views/12?pane=issue&itemId=25824299

Description

If strings to be converted have quotes nested within them, we throw an error here. I don't know where we should solve this problem, but it requires more than just a few regexs. I went for a really complex solution but it just doesn't work without parsing. Maybe I missed something, but I'd like to get the core fix out before we find a complete solution to strings with nested quotes and nested templates.

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@team-tf-cdk
Copy link
Collaborator

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@mutahhir mutahhir marked this pull request as ready for review April 18, 2023 09:59
@mutahhir mutahhir requested a review from a team as a code owner April 18, 2023 09:59
@mutahhir mutahhir requested review from ansgarm and Maed223 and removed request for a team April 18, 2023 09:59
@mutahhir mutahhir changed the title Fix/accept escaped quotes fix: Accept nested quotes within strintgs Apr 18, 2023
@mutahhir mutahhir changed the title fix: Accept nested quotes within strintgs fix: Accept nested quotes within strings Apr 18, 2023
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants