Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Improve telemetry reporting #2840

Merged
merged 11 commits into from
Jun 7, 2023
Merged

Conversation

Maed223
Copy link
Contributor

@Maed223 Maed223 commented Apr 25, 2023

Description

Fills holes in our telemetry in the following ways:

  • Synth: adds language and provider info
  • Get: Fixes the payload that was previously sending an empty object
  • Diff/Deploy/Destroy: Add telemetry events that includes stack metadata, provider usage, failed stack reports

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@Maed223 Maed223 force-pushed the improve-telemetry-reporting branch from 17be3e7 to 4a71962 Compare April 30, 2023 18:35
@Maed223 Maed223 marked this pull request as ready for review April 30, 2023 19:22
@Maed223 Maed223 requested a review from a team as a code owner April 30, 2023 19:22
@Maed223 Maed223 requested review from mutahhir and ansgarm and removed request for a team April 30, 2023 19:22
@mutahhir mutahhir force-pushed the improve-telemetry-reporting branch from 4a71962 to 878ab2f Compare June 5, 2023 14:45
Merged via the queue into main with commit a03bc2d Jun 7, 2023
276 of 295 checks passed
@mutahhir mutahhir deleted the improve-telemetry-reporting branch June 7, 2023 10:22
@xiehan xiehan added this to the 0.17 milestone Jun 14, 2023
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants