Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add regression test for input on init #2978

Merged
merged 1 commit into from
Jul 3, 2023
Merged

chore: Add regression test for input on init #2978

merged 1 commit into from
Jul 3, 2023

Conversation

mutahhir
Copy link
Contributor

@mutahhir mutahhir commented Jul 3, 2023

Description

I missed adding a regression test for the issue fixed in #2977. This PR adds that.

Checklist

  • I have updated the PR title to match CDKTF's style guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

@mutahhir mutahhir requested a review from a team as a code owner July 3, 2023 09:12
@mutahhir mutahhir requested review from ansgarm and DanielMSchmidt and removed request for a team July 3, 2023 09:12
@mutahhir mutahhir added this pull request to the merge queue Jul 3, 2023
Merged via the queue into main with commit 9b2b1db Jul 3, 2023
32 checks passed
@mutahhir mutahhir deleted the chore/add-tests-for-init-input branch July 3, 2023 09:20
@mutahhir mutahhir mentioned this pull request Jul 5, 2023
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ansgarm ansgarm ansgarm approved these changes

@DanielMSchmidt DanielMSchmidt Awaiting requested review from DanielMSchmidt DanielMSchmidt is a code owner automatically assigned from hashicorp/cdktf

Assignees
No one assigned
Labels
ci/run-unit/cdktf-cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mutahhir @ansgarm @team-tf-cdk