fix(examples): Properly set the Aspect on the stack instead of on the S3Bucket only #3003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansgarm
requested review from
mutahhir and
DanielMSchmidt
and removed request for
a team
DanielMSchmidt
approved these changes
Jul 12, 2023
… S3Bucket only This also removes the need for another Aspect instance to test that it does work with the pet resource, as adding it to the stack will also invoke it for the pet resource This change helps users that read the source of this example as adding an Aspect to a single resource serves not much purpose
ansgarm
force-pushed
the
improve-python-aspects-source
branch
from
b0b0deb
to
7957b1b
Compare
|
(merged even though the Java Google example failed – but it fails everywhere currently) |
Merged
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also removes the need for another Aspect instance to test that it does work with the pet resource, as adding it to the stack will also invoke it for the pet resource
This change helps users that read the source of this example as adding an Aspect to a single resource serves not much purpose