Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(#644): Upgrade python templates to use RemoteBackend class #669

Merged
merged 1 commit into from
May 13, 2021

Conversation

bradseiler
Copy link
Contributor

Addresses issue #644

Tested locally by initializing the python template project and successfully generating the cdk.tf.json output:

{
  "//": {
    "metadata": {
      "version": "0.0.0",
      "stackName": "python-example"
    }
  },
  "terraform": {
    "backend": {
      "remote": {
        "organization": "bradseiler-test",
        "workspaces": {
          "name": "python"
        },
        "hostname": "app.terraform.io"
      }
    }
  }
}

@hashicorp-cla
Copy link

hashicorp-cla commented Apr 30, 2021

CLA assistant check
All committers have signed the CLA.

@skorfmann
Copy link
Contributor

@bradseiler thanks for the fix - please make sure to sign the CLA - we can't merge without this.

@bradseiler
Copy link
Contributor Author

Thanks @skorfmann, we just executed a corporate CLA between Square and Hashicorp, @cneralich should have it. I'm submitting this as a work product on behalf of Square.

@danieldreier danieldreier added this to the v0.4 milestone May 11, 2021
@danieldreier
Copy link
Contributor

Thanks @bradseiler! I'm investigating why the CLA approval hasn't come through yet, and am excited to get this fix merged. Thank you for contributing!

@danieldreier danieldreier merged commit 1b566fc into hashicorp:main May 13, 2021
@danieldreier
Copy link
Contributor

@bradseiler I followed-up and we got the CLA authorization sorted out, so I was able to merge this. Thank you for this fix!

@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants