Deploy changes on TF output changes #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielMSchmidt
force-pushed
the
fix-481-output-not-picked-up
branch
from
f6347a8
to
209f14f
Compare
DanielMSchmidt
commented
May 6, 2021
| const applyActions = [PlannedResourceAction.UPDATE, PlannedResourceAction.CREATE, PlannedResourceAction.DELETE, PlannedResourceAction.READ]; | ||
| return resources.filter(resource => (applyActions.includes(resource.action))); | ||
| } | ||
| export abstract class AbstractTerraformPlan implements TerraformPlan { |
There was a problem hiding this comment.
I abstracted the data mangling work and business logic into an abstract class to DRY things up, hope that works for y'all :)
There was a problem hiding this comment.
Sounds good. Just make sure to consider #449 (comment)
There was a problem hiding this comment.
Yeah good point, I tested this as well :)
DanielMSchmidt
force-pushed
the
fix-481-output-not-picked-up
branch
2 times, most recently
from
8ed6df1
to
3c33477
Compare
This was referenced May 11, 2021
DanielMSchmidt
force-pushed
the
fix-481-output-not-picked-up
branch
from
3c33477
to
8bfac0e
Compare
ansgarm
approved these changes
May 11, 2021
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #481, Fixes #695