feat(lib): make asset paths change if asset content changes #769
+37
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielMSchmidt
force-pushed
the
unique-asset-paths
branch
from
a6c5aa6
to
92a7855
Compare
ansgarm
reviewed
Jun 15, 2021
| @@ -3,10 +3,10 @@ | |||
| exports[`full integration test deploy in Terraform Cloud 1`] = ` | |||
| "Deploying Stack: hello-terra | |||
| Resources | |||
| ✔ NULL_RESOURCE test null_resource.test | |||
| ~ NULL_RESOURCE test null_resource.test | |||
There was a problem hiding this comment.
No, I hoped that it was fixed with the JSON parsing
There was a problem hiding this comment.
I'll try a rebase, unsure if it has been lately
DanielMSchmidt
force-pushed
the
unique-asset-paths
branch
2 times, most recently
from
cf896a6
to
6585e3f
Compare
DanielMSchmidt
force-pushed
the
unique-asset-paths
branch
2 times, most recently
from
0b02972
to
21d32ad
Compare
DanielMSchmidt
force-pushed
the
unique-asset-paths
branch
2 times, most recently
from
4269fca
to
174f26a
Compare
DanielMSchmidt
force-pushed
the
unique-asset-paths
branch
7 times, most recently
from
14979ba
to
b3830ea
Compare
DanielMSchmidt
force-pushed
the
unique-asset-paths
branch
from
b3830ea
to
1bb9fca
Compare
skorfmann
reviewed
Aug 9, 2021
|
@skorfmann I added this now, I don't think it's necessary right now as we clean the entire directory in the beginning, but now we can be sure we don't break anything once we change this behavior |
this will be necessary once we stop removing the entire out folder on synth
DanielMSchmidt
force-pushed
the
unique-asset-paths
branch
from
fa4959c
to
a9a3bc2
Compare
skorfmann
reviewed
Aug 10, 2021
skorfmann
approved these changes
Aug 11, 2021
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #762