Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): add prettier #793

Merged
merged 4 commits into from
Jun 29, 2021
Merged

chore(cli): add prettier #793

merged 4 commits into from
Jun 29, 2021

Conversation

DanielMSchmidt
Copy link
Contributor

@DanielMSchmidt DanielMSchmidt commented Jun 23, 2021

Prettier helps us have a consistent code style. I'm intentionally using the default configuration as I don't want to bring my own preferred code style in too much.

This PR contains:

  • a pre-commit hook that formats staged files (with no user interaction for installing or within commiting)
  • a check that turns the tests red if files are not formatted
  • a command to run formatting over all files (probably not going to be used much)

While reviewing, please ignore the last two commits, they are applying the new code styles.

Please run

  1. git cherry-pick 20be6036dff274aaf808f3584bfa6a53942cb2c8
  2. git cherry-pick f7a45182ac0dec6be4c174bc6573e69bd0b10ae5
  3. yarn
  4. yarn format
  5. git pull origin main --rebase

to bring your branch up to date

@DanielMSchmidt DanielMSchmidt force-pushed the prettier branch 16 times, most recently from bc30215 to 5041783 Compare June 24, 2021 13:06
@DanielMSchmidt DanielMSchmidt merged commit 2050954 into main Jun 29, 2021
@DanielMSchmidt DanielMSchmidt deleted the prettier branch June 29, 2021 09:31
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants