fix(lib): Module references to providers synthesizes array instead of map #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ansgarm
changed the title
jsteinich
requested changes
Aug 26, 2021
|
Also, please make sure to sign the CLA as stated in this comment |
marekmoscichowski
force-pushed
the
fix/providers
branch
from
7d6a8c1
to
eb57c7a
Compare
jsteinich
approved these changes
Sep 2, 2021
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #901
I've changed snapshots to match map instead of list and changed the implementation to match.
If I understand correctly
multiple providerstest was invalid. Terraform can't pass multiple providers with the same key. Especially when we need to produce a map. I introduced an error throw when providers are not unique.