Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): enable windows test with escapes #957

Merged
merged 7 commits into from Sep 12, 2021

Conversation

jsteinich
Copy link
Collaborator

Fixes #810

@jsteinich jsteinich changed the title fix(test): enable windows test with escapes fix(tests): enable windows test with escapes Sep 8, 2021
@jsteinich jsteinich force-pushed the enable_windows_multi_stack_test branch from b7079b4 to ec6926b Compare September 8, 2021 03:58
@jsteinich
Copy link
Collaborator Author

error TS2304: Cannot find name 'onWindows'. I'm not really sure why it isn't finding the defined constant. I didn't have that issue locally.

@ansgarm
Copy link
Member

ansgarm commented Sep 8, 2021

@jsteinich
I think that was moved to some test utility quite recently because it was re-used in another test case as well.
https://github.com/hashicorp/terraform-cdk/blob/main/test/test-helper.ts#L212

@jsteinich jsteinich force-pushed the enable_windows_multi_stack_test branch from ec6926b to 1121a77 Compare September 9, 2021 02:36
@hashicorp-cla
Copy link

hashicorp-cla commented Sep 9, 2021

CLA assistant check
All committers have signed the CLA.

@jsteinich
Copy link
Collaborator Author

Thanks @ansgarm. Found it and now the specific test is passing. Just failing the terraform cloud test now.

@ansgarm
Copy link
Member

ansgarm commented Sep 9, 2021

Just failing the terraform cloud test now.

Ah, well. We had some weird trouble with that one recently.

@jsteinich
Copy link
Collaborator Author

Seems like we might have some new flakiness with our tests, but the latest run did pass everything.

@ansgarm ansgarm merged commit 51e2cea into hashicorp:main Sep 12, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-enable Snapshot test for windows
3 participants