Skip to content
This repository has been archived by the owner on Jan 25, 2023. It is now read-only.

Add support for custom subnetworks #5

Merged
merged 2 commits into from
May 24, 2018

Conversation

oralordos
Copy link
Contributor

This should add in support for custom subnetworks while still supporting any of the older flows. A standard custom network still works, and a custom subnetwork will also work.

Fixes #4

@dalekurt
Copy link

Thank you @oralordos I truly appreciate the work you have been doing.

@mkell43
Copy link

mkell43 commented May 17, 2018

@josh-padnick or other, could this please be merged in? I don't mind using @oralordos's fork, but I would rather be pulling from the official repo.

@brikis98
Copy link
Collaborator

@josh-padnick Is on vacation at the moment, but we'll dig into this when he's back next week. Thank you for your patience!

@josh-padnick
Copy link
Collaborator

josh-padnick commented May 24, 2018

Hi all, apologies for the delay in responding. It wasn't clear how to prioritize reviewing these requests internally and the lack of automated tests made it harder to do so. We've now made the decision to commit to timely responses on the Gruntwork-managed GCP Terraform modules.

For this PR in particular, until GCP support lands in Terratest, we'll need contributors to explicitly verify that they manually tested the changes. In this case, the changes are backwards-compatible, and I validated one set of inputs, so I'll merge now!

@josh-padnick josh-padnick merged commit bb7fb48 into hashicorp:master May 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants