Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform/exec: Pass through all environment variables #139

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Jun 5, 2020

Closes #138

This should address many use cases where some form of external auth provider is being looked up by the provider or state backend.
e.g. https://docs.aws.amazon.com/eks/latest/userguide/install-aws-iam-authenticator.html in case of Kubernetes or az (Azure CLI) in case of AzureRM.

and also allow authentication from behind a corporate proxy, which can be configured on the workstation in such a way that the address of the proxy server is in standard environment variables.

We pass through all variables that are given to the server, which means that these could be reused between different workspaces, but this should be fairly safe for now, because

a) the language server doesn't execute terraform command that could do damage when provided wrong variables. We are working with the assumption that terraform providers schema -json does not push state.
b) we only allow one workspace at a time to be initialized anyway

@radeksimko radeksimko added the bug Something isn't working label Jun 5, 2020
@radeksimko radeksimko changed the title terraform/exec: Whitelist auth-related ENV variables terraform/exec: Pass through all environment variables Jun 5, 2020
@radeksimko radeksimko merged commit c130de0 into master Jun 5, 2020
@radeksimko radeksimko deleted the f-whitelist-env branch June 5, 2020 11:43
@ghost
Copy link

ghost commented Jul 5, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Jul 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terrafor 2.0.0rc1: Unable to retrieve schemas: failed to get schemas: terraform
2 participants