-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ParseModuleConfiguration to only parse changed file (*.tf
)
#1404
Conversation
01cad71
to
50fcdf4
Compare
a0ab82f
to
c207c65
Compare
31152fe
to
d4170e1
Compare
Co-authored-by: Radek Simko <radek.simko@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor nitpicky suggestions, feel free to merge once applied.
Co-authored-by: Radek Simko <radek.simko@gmail.com>
*.tf
)
Modifies ParsedVarsFiles to only re-parse the single tfvars file which is being changed, if the job was scheduled as part of `textDocument/didChange` request. This is a follow up to #1404 which updated the parsing job for terraform files.
Modifies ParsedVarsFiles to only re-parse the single tfvars file which is being changed, if the job was scheduled as part of `textDocument/didChange` request. This is a follow up to #1404 which updated the parsing job for terraform files.
Modifies ParsedVarsFiles to only re-parse the single tfvars file which is being changed, if the job was scheduled as part of `textDocument/didChange` request. This is a follow up to #1404 which updated the parsing job for terraform files.
Modifies ParsedVarsFiles to only re-parse the single tfvars file which is being changed, if the job was scheduled as part of `textDocument/didChange` request. This is a follow up to #1404 which updated the parsing job for terraform files.
Modifies ParsedVarsFiles to only re-parse the single tfvars file which is being changed, if the job was scheduled as part of `textDocument/didChange` request. This is a follow up to #1404 which updated the parsing job for terraform files.
Modifies ParsedVarsFiles to only re-parse the single tfvars file which is being changed, if the job was scheduled as part of `textDocument/didChange` request. This is a follow up to #1404 which updated the parsing job for terraform files.
Modifies ParsedVarsFiles to only re-parse the single tfvars file which is being changed, if the job was scheduled as part of `textDocument/didChange` request. This is a follow up to #1404 which updated the parsing job for terraform files.
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
This modifies ParseModuleConfiguration to only parse changed file if file already parsed and this is a didChange request.
Previously ParseModuleConfiguration would reparse not only the changed file but also the module containing the changed file.
Now ParseModuleConfiguration detects if the file has previously been parsed and the request is from a didChange event. If both are true, then it only parses the changed file and skips re-parsing the entire module. If this is false, it falls back to the previous behavior of re-parsing the entire module including the changed file.