Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watcher: Refresh versions when plugin lockfile changes #403

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Feb 9, 2021

When lock file changes we always reload the schema but it is likely that provider versions may have also changed and therefore we need to reload that too.

@radeksimko radeksimko added the bug Something isn't working label Feb 9, 2021
@radeksimko radeksimko changed the title watcher: Refresh versions when schema changes watcher: Refresh versions when plugin lockfile changes Feb 9, 2021
@radeksimko radeksimko marked this pull request as ready for review February 9, 2021 20:14
@radeksimko radeksimko requested a review from a team February 9, 2021 20:20
Copy link
Contributor

@aeschright aeschright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@radeksimko radeksimko merged commit 5477c7d into main Feb 12, 2021
@radeksimko radeksimko deleted the b-watcher-get-version branch February 12, 2021 08:33
@ghost
Copy link

ghost commented Mar 14, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants