-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for traversals/references #485
Conversation
04eb478
to
a7791e4
Compare
8a7bb79
to
9372020
Compare
} | ||
|
||
// TODO: Omit item which uses kind unsupported by the client | ||
|
||
var cmd *lsp.Command | ||
if candidate.TriggerSuggest { | ||
if candidate.TriggerSuggest && snippetSupport { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably something that should've been done some time ago. We do not include the =
in the simplified TextEdits and so triggering suggest in that case is kind of pointless.
It is not a big deal for most clients today which probably do support snippets anyway, but it also helps reducing the amount of test data where in test we opt into snippet support only where we need it.
4e9a443
to
b992415
Compare
b992415
to
0b882cb
Compare
0b882cb
to
52157a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Builds on hashicorp/hcl-lang#36
Builds on hashicorp/terraform-schema#41
Some known (most likely desirable) features were intentionally left out from the MVP, but are tracked individually and will be eventually implemented:
type
declarations: Support for type declarations (for variabletype
) #490var.x
orlocal.x
): Support for references to variables and locals #491module
outputs & completion of inputs: Completion of module variables in module block #93Generally if something related to reference completion/hover etc. seems missing from that list, or the implementation I would suggest opening a new issue (rather than commenting here on this PR).
Screenshots