Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid publishing stale 'validate' diagnostics #603

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Aug 2, 2021

Fixes #524

Before

2021-08-03 08 32 46

After

2021-08-03 08 37 19


The "silent delay" is an effect of VS Code not supporting progress reporting during command execution microsoft/vscode-languageserver-node#528 (comment)

@radeksimko radeksimko added the bug Something isn't working label Aug 2, 2021
@radeksimko radeksimko merged commit 76b4416 into main Aug 3, 2021
Terraform Editor Experience Public Roadmap automation moved this from In Progress to Done Aug 3, 2021
@radeksimko radeksimko deleted the b-avoid-stale-diags branch August 3, 2021 10:14
@github-actions
Copy link

github-actions bot commented Sep 3, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

validate diagnostics not being cleared on file change/closing or revalidation
1 participant