Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement ignorelist for module indexing #696

Merged
merged 10 commits into from
Nov 8, 2021
Merged

Implement ignorelist for module indexing #696

merged 10 commits into from
Nov 8, 2021

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Nov 4, 2021

This PR adds a new setting called ignoreDirectoryNames to the language server. It's now possible to send a list of directories on initialize, which should be ignored by the walker and never be indexed.

Closes #670

@dbanck dbanck mentioned this pull request Nov 4, 2021
Merged
@dbanck dbanck marked this pull request as ready for review November 4, 2021 15:02
radeksimko
radeksimko approved these changes Nov 8, 2021
View reviewed changes
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good, well done! I only left a few minor comments/suggestions. Feel free to merge once addressed.

You may want to use the squash option when merging, or rebase to squash the commits.

internal/settings/settings.go Outdated Show resolved Hide resolved
internal/settings/settings_test.go Outdated Show resolved Hide resolved
internal/settings/settings_test.go Outdated Show resolved Hide resolved
internal/langserver/handlers/initialize_test.go Show resolved Hide resolved
docs/SETTINGS.md Outdated Show resolved Hide resolved
@radeksimko radeksimko added the enhancement New feature or request label Nov 8, 2021
dbanck and others added 2 commits November 8, 2021 09:58
@dbanck @radeksimko
Apply suggestions from code review
a916f0f 
Co-authored-by: Radek Simko <radek.simko@gmail.com>
@dbanck
fix test
6e712ce
@dbanck dbanck merged commit fe7b087 into main Nov 8, 2021
@dbanck dbanck deleted the f-670-config-ignorelist branch November 8, 2021 10:09
Terraform Editor Experience Public Roadmap automation moved this from In Progress to Done Nov 8, 2021
@github-actions
Copy link

github-actions bot commented Dec 9, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radeksimko radeksimko radeksimko approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
Terraform Editor Experience Public Ro...
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make ignorelist for module indexing configurable
2 participants
@dbanck @radeksimko