Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignoreDirectoryNames setting for language server configuration #833

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Nov 4, 2021

This PR adds support for the new ignoreDirectoryNames language server side config option.

Needs hashicorp/terraform-ls#696 to merge.

@dbanck dbanck force-pushed the add-ignoreDirectoryNames-setting branch from c40dcd2 to 699162a Compare November 4, 2021 10:47
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

FYI @jpogran this may also conflict with #834

@dbanck dbanck merged commit 4356475 into main Nov 8, 2021
@dbanck dbanck deleted the add-ignoreDirectoryNames-setting branch November 8, 2021 12:48
Terraform Editor Experience Public Roadmap automation moved this from In Progress to Done Nov 8, 2021
@github-actions
Copy link

github-actions bot commented Dec 9, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants