Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing references for some blocks in a separate config file #829

Merged
merged 2 commits into from
Mar 14, 2022

Conversation

radeksimko
Copy link
Member

This brings in hashicorp/hcl-lang#105 which also describes the root cause of the problem. I also attached a test to ensure this doesn't reoccur in the future, although the fix is already tested upstream.

Fixes #646

@radeksimko radeksimko added bug Something isn't working textDocument/completion labels Mar 14, 2022
@radeksimko radeksimko requested a review from a team March 14, 2022 16:18
@radeksimko radeksimko added this to the v0.26.0 milestone Mar 14, 2022
@radeksimko radeksimko self-assigned this Mar 14, 2022
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for including the test case here as well

@radeksimko radeksimko merged commit 50f67f0 into main Mar 14, 2022
@radeksimko radeksimko deleted the b-missing-ref-target branch March 14, 2022 16:42
@github-actions
Copy link

This functionality has been released in v0.26.0 of the language server.
If you use the official Terraform VS Code extension, it will prompt you to upgrade to this version automatically upon next launch or within the next 24 hours.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working textDocument/completion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing references for blocks in a separate config file
2 participants