Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group nested attributes by optional, required and read-only #163

Merged
merged 3 commits into from Jul 5, 2022

Conversation

adnsio
Copy link
Contributor

@adnsio adnsio commented Jun 30, 2022

In the current implementation the docs of a nested schema use the title (optional, required and read-only) of the parent. With this PR the attributes of the nested schema will be grouped according to their settings.

Demo: https://registry.terraform.io/providers/adnsio/k0s/latest/docs/resources/cluster

@hashicorp-cla
Copy link

hashicorp-cla commented Jun 30, 2022

CLA assistant check
All committers have signed the CLA.

@adnsio adnsio marked this pull request as ready for review Jun 30, 2022
@adnsio adnsio requested a review from a team as a code owner Jun 30, 2022
@adnsio adnsio changed the title Group nested attributes by optional, required and computed value Group nested attributes by optional, required and read-only (computed) Jun 30, 2022
@adnsio adnsio changed the title Group nested attributes by optional, required and read-only (computed) Group nested attributes by optional, required and read-only Jun 30, 2022
@detro
Copy link
Contributor

detro commented Jul 1, 2022

Hey @adnsio - thank you for this.

Given this is going to result in a change in behaviour, this is likely requiring a minor release (0.13.0, as we speak). CHANGELOG needs to be updated accordingly.

Additionally, this might require me to do some manual testing, as the current regression testing automation in this repository is wanting.

detro
detro approved these changes Jul 5, 2022
@detro detro merged commit 0aa71ca into hashicorp:main Jul 5, 2022
1 check passed
@detro detro added this to the v0.13.0 milestone Jul 5, 2022
@adnsio adnsio deleted the nested-attribute-groups branch Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants