Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tf5muxserver+tf6muxserver: Replace Schema tftypes.Type Functions With terraform-plugin-go ValueType() Methods #58

Closed
bflad opened this issue Feb 17, 2022 · 1 comment · Fixed by #64
Closed

tf5muxserver+tf6muxserver: Replace Schema tftypes.Type Functions With terraform-plugin-go ValueType() Methods #58

bflad opened this issue Feb 17, 2022 · 1 comment · Fixed by #64
Assignees
@bflad
Milestone
v0.7.0

Comments

@bflad
Copy link
Contributor

bflad commented Feb 17, 2022

terraform-plugin-mux version

v0.5.0

Use cases

As part of #54, unexported functions to convert schemas into their associated types were introduced into tf5muxserver and tf6muxserver. Those functions have been implemented upstream into terraform-plugin-go as ValueType() methods on the various schema types, making them extraneous in these packages.

Proposal

When hashicorp/terraform-plugin-go#158 is part of a tagged release and the dependency updated in this module, these functions should be removed in preference of the upstream implementation.
bflad added a commit that referenced this issue Feb 22, 2022
@bflad
tf5muxserver+tf6muxserver: Replace Schema tftypes.Type Functions With…
eead296 
… terraform-plugin-go ValueType() Methods

Reference: #58
@bflad bflad mentioned this issue Feb 22, 2022
Closed
@bflad bflad self-assigned this Mar 10, 2022
@bflad bflad added this to the v0.7.0 milestone Mar 10, 2022
bflad added a commit that referenced this issue Mar 10, 2022
@bflad
tf5muxserver+tf6muxserver: Use new terraform-plugin-go schema ValueTy…
24c8e35 
…pe methods

Reference: #58

No CHANGELOG entry is necessary as this is purely technical debt cleanup.
@bflad bflad mentioned this issue Mar 10, 2022
Merged
@bflad bflad closed this as completed in #64 Mar 11, 2022
bflad added a commit that referenced this issue Mar 11, 2022
@bflad
tf5muxserver+tf6muxserver: Use new terraform-plugin-go schema ValueTy…
8bf5fca 
…pe methods (#64)

Reference: #58

No CHANGELOG entry is necessary as this is purely technical debt cleanup.
@github-actions GitHub Actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bflad bflad

Labels
None yet
Projects
None yet
Milestone
v0.7.0
1 participant
@bflad