tfprotov5+tfprotov6: Introduce ValueType() methods for Schema types #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference: #128 Reference: #157 This methods implement standard conversion logic from `Schema*` types into their associated `tftypes.Type` equivalent. For example, these can be used to prepare calls to the `(DynamicValue).Unmarshal()` method, which is necessary in many RPCs. Preferably, these methods would have been named `Type()`, however the `SchemaAttribute` type implements a `Type` field and Go does not permit overlapping field and method names. Instead, the name `ValueType()` was chosen as an alternate designation as the `tftypes.Type` really represents a data value type, instead of a type constraint (sometimes also referred to as a schema type).
detro
approved these changes
Feb 17, 2022
|
/cc @alexsomesan you may find these useful for replacing some manifest provider logic 👍 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #128
Closes #157
This methods implement standard conversion logic from
Schema*types into their associatedtftypes.Typeequivalent. For example, these can be used to prepare calls to the(DynamicValue).Unmarshal()method, which is necessary in many RPCs.Preferably, these methods would have been named
Type(), however theSchemaAttributetype implements aTypefield and Go does not permit overlapping field and method names. Instead, the nameValueType()was chosen as an alternate designation as thetftypes.Typereally represents a data value type, instead of a type constraint (sometimes also referred to as a schema type).