ResourceData: create variadic 'HasChanges' method #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appilon
changed the title
appilon
force-pushed
the
variadic-has-change
branch
2 times, most recently
from
7727111
to
5017177
Compare
appilon
force-pushed
the
variadic-has-change
branch
from
5017177
to
7f3aaae
Compare
appilon
changed the title
katbyte
approved these changes
Nov 9, 2019
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm open to bikeshedding on the function name. Strongest alternative probablyVoted onHasChanges(this alternative just "feels better" thanHaveChangeI may switch if there is support for it)?HasChangesPractically speaking we could have switchedHasChangeitself to be variadic and it likely wouldn't have broken anything in the real world, however from a compiled language/type signature point of view anyone who has assigned this method (unlikely) would experience a breaking change (the rare L for compiled languages).Also I'm allowing a noop call
d.HasChanges()I wasn't sure maybe it should panic without a single key? Could change signature toCloses #194