Fix issue #710 #711
Merged
Fix issue #710 #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compare resource attribute values more reliable. Use Equal method from Set even if Set is not on the top of the tree.
|
|
|
Is there anything I can do to help get this merged/released? It'd be great as the solve for hashicorp/terraform-provider-aws#13658. |
richstokes
approved these changes
Jul 22, 2021
inhumantsar
approved these changes
Aug 6, 2021
bflad
approved these changes
Oct 12, 2021
There was a problem hiding this comment.
Thank you for this, @oliver-schoenherr 🚀 I'm going to pull this in, after double checking it against terraform-provider-corner, with the two testing adjustments noted below.
bflad
added a commit
that referenced
this pull request
Oct 12, 2021
This was referenced Oct 14, 2021
Closed
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
hasChangedfunction does not take in consideration that the special case comparing aSetcan happen on any level of the tree, not only on the top.Instead of copy the
reflect.DeepEqualfunction I just use thego-cmplibrary, which is already used in the code base, but for testing purpose only.