v1: fixing timeouts

[tombuildsstuff]

Discovered when upgrading hashicorp/terraform-provider-azurerm#11431

The latest changes to one of the dependencies, presumably terraform-exec, return the Duration as a json.Number rather than the expected time.Duration, int64 or float64, hence this fails silently with the log message:

2021/04/22 11:01:20 [WARN] Unknown type in DefaultTimeout: "5400000000000"
2021/04/22 11:01:20 [WARN] Unknown type in DefaultTimeout: "300000000000"
2021/04/22 11:01:20 [WARN] Unknown type in DefaultTimeout: "5400000000000"
2021/04/22 11:01:20 [WARN] Unknown type in DefaultTimeout: "5400000000000

When expanding that log message to include the type (without the new switch item) - this becomes:

[WARN] Unknown type json.Number in DefaultTimeout: “5400000000000”

Arguably this warning should be a Panic and not a Warning, but that's probably outside the scope of this fix. It also appears that this affects v2 as well as v1 - so this may need to be applied to v2 as well?

terraform-plugin-sdk/helper/schema/resource_timeout.go

Lines 35 to 49 in 112e216

	// could be time.Duration, int64 or float64
	func DefaultTimeout(tx interface{}) *time.Duration {
	var td time.Duration
	switch raw := tx.(type) {
	case time.Duration:
	return &raw
	case int64:
	td = time.Duration(raw)
	case float64:
	td = time.Duration(int64(raw))
	default:
	log.Printf("[WARN] Unknown type in DefaultTimeout: %#v", tx)
	}
	return &td
	}

[tombuildsstuff]

Closing in favour of #748

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.