tree-wide: fix references to the terraform-providers organization

[flokli]

terraform-provider-archive has been moved to the hashicorp
organization.

[flokli]

@appilon could you take a look at this, and the other PRs?

They all fix broken references after the org transfer:

• tree-wide: fix references to the terraform-providers organization #67
• tree-wide: fix references to the terraform-providers organization terraform-provider-local#40
• tree-wide: fix references to the terraform-providers organization terraform-provider-null#43
• tree-wide: fix references to the terraform-providers organization terraform-provider-template#79
• tree-wide: fix references to the terraform-providers organization terraform-provider-external#41
• tree-wide: fix references to the terraform-providers organization terraform-provider-http#40
• tree-wide: fix references to the terraform-providers organization terraform-provider-tls#71
• tree-wide: fix references to the terraform-providers organization terraform-provider-dns#101
• tree-wide: fix references to the terraform-providers organization terraform-provider-random#107

Thanks!

[flokli]

ping ;-)

[kmoe]

Thank you for the PR.

We do not support importing Terraform providers as Go modules, so it is not necessary to update the module path for this provider. Please see our best practice documentation.

While we appreciate the effort that goes into preparing PRs, there is always a tradeoff between benefit and cost. In this case, the proposed change would break in-flight pull requests for this provider, creating extra vendor diffs and extra work for our contributors. We therefore will not merge this PR at this time.

If the module path is causing issues with something besides importing the provider, we'd love to hear more about it. Reply to this issue and let us know what you're trying to do, and we'll look into it.

[flokli]

Thanks for getting back to me on this.

If the module path is causing issues with something besides importing the provider, we'd love to hear more about it. Reply to this issue and let us know what you're trying to do, and we'll look into it.

I don't import Terraform providers as a go module in my code, but the build tooling and packaging code around fails to build with the wrong names. Please see the referencing issue NixOS/nixpkgs#83279 for details and the other issues linked in #67 (comment) for the fallout currently required to get them to build.

I don't really see how this can largely affect other in-flight pull requests - it shouldn't change any vendor diffs in this repo, and this is mostly to be consistent with where the code now lives.

[flokli]

Also note the current approach seems to be named the "module name workaround", and fixing the references, as proposed here and in the other 8 PRs seems to be preferred, as per hashicorp/terraform-provider-helm#522:

Instead of using the module name workaround from step 7 of the migration RFC
(https://docs.google.com/document/d/1PQFAhpTgUhHcZxIIWapNsa0UTPOeC5y8DO0zuV1mqCk/edit?ts=5ed8d6e0)
it's more straightforward to just rename the module.

The PRs did all the heavy lifting, the number of other in-flight PRs affected by this is pretty minimal, and sticking with the workaround is causing problems currently just pushed to downstream packagers.

Please reconsider, also cc @dak1n1 @aareet .