Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree-wide: fix references to the terraform-providers organization #41

Closed
wants to merge 1 commit into from

Conversation

flokli
Copy link

@flokli flokli commented Apr 2, 2020

terraform-provider-external has been moved to the hashicorp
organization.

`terraform-provider-external` has been moved to the `hashicorp`
organization.
@kmoe
Copy link
Member

kmoe commented Jun 26, 2020

Thank you for the PR.

We do not support importing Terraform providers as Go modules, so it is not necessary to update the module path for this provider. Please see our best practice documentation.

While we appreciate the effort that goes into preparing PRs, there is always a tradeoff between benefit and cost. In this case, the proposed change would break in-flight pull requests for this provider, creating extra vendor diffs and extra work for our contributors. We therefore will not merge this PR at this time.

If the module path is causing issues with something besides importing the provider, we'd love to hear more about it. Reply to this issue and let us know what you're trying to do, and we'll look into it.

@kmoe kmoe closed this Jun 26, 2020
@flokli
Copy link
Author

flokli commented Jul 6, 2020

Thanks for getting back to me on this.

If the module path is causing issues with something besides importing the provider, we'd love to hear more about it. Reply to this issue and let us know what you're trying to do, and we'll look into it.

I don't import Terraform providers as a go module in my code, but the build tooling and packaging code around fails to build with the wrong names. Please see the referencing issue NixOS/nixpkgs#83279 for details and the other issues linked in hashicorp/terraform-provider-archive#67 (comment) for the fallout currently required to get them to build.

I don't really see how this can largely affect other in-flight pull requests - it shouldn't change any vendor diffs in this repo, and this is mostly to be consistent with where the code now lives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants