Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Data Source: aws_ec2_local_gateway_virtual_interface_group #13502

Closed
bflad opened this issue May 26, 2020 · 3 comments · Fixed by #13767
Closed

New Data Source: aws_ec2_local_gateway_virtual_interface_group #13502

bflad opened this issue May 26, 2020 · 3 comments · Fixed by #13767
Assignees
@bflad
Labels
new-data-source Introduces a new data source. service/ec2 Issues and PRs that pertain to the ec2 service.
Milestone
v2.67.0

Comments

@bflad
Copy link
Contributor

bflad commented May 26, 2020

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Support the ability to read a EC2 Local Gateway Virtual Interface Group, in preparation for connecting Outposts to on-premise networks via EC2 Local Gateway Routes.

New Data Source

  • aws_ec2_local_gateway_virtual_interface_group

Potential Terraform Configuration

data "aws_ec2_local_gateway_virtual_interface_group" "example" {
  filter {
    name   = "local-gateway-id"
    values = [data.aws_ec2_local_gateway.example.id]
  }
}

References
@bflad bflad added new-data-source Introduces a new data source. service/ec2 Issues and PRs that pertain to the ec2 service. labels May 26, 2020
@bflad bflad self-assigned this May 26, 2020
This was referenced May 26, 2020
Closed
Closed
Closed
bflad added a commit that referenced this issue Jun 16, 2020
@bflad
New Data Sources: aws_ec2_local_gateway_virtual_interface_group(s)
242d9e8 
Reference: #13502

Output from acceptance testing:

```
--- PASS: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_LocalGatewayId (17.89s)
--- PASS: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_Filter (18.16s)

--- PASS: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_basic (16.94s)
--- PASS: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_Filter (21.14s)
```
@bflad bflad mentioned this issue Jun 16, 2020
Merged
bflad added a commit that referenced this issue Jun 16, 2020
@bflad
New Data Sources: aws_ec2_local_gateway_virtual_interface_group(s)
e072411 
Reference: #13502

Output from acceptance testing:

```
--- PASS: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_LocalGatewayId (17.89s)
--- PASS: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_Filter (18.16s)

--- PASS: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_basic (16.94s)
--- PASS: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_Filter (21.14s)
```
@bflad bflad added this to the v2.67.0 milestone Jun 16, 2020
bflad added a commit that referenced this issue Jun 16, 2020
@bflad
New Data Sources: aws_ec2_local_gateway_virtual_interface_group(s) (#…
6cb8a5e 
…13767)

* New Data Sources: aws_ec2_local_gateway_virtual_interface_group(s)

Reference: #13502

Output from acceptance testing:

```
--- PASS: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_LocalGatewayId (17.89s)
--- PASS: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_Filter (18.16s)

--- PASS: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_basic (16.94s)
--- PASS: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_Filter (21.14s)
```

* service/ec2: Ensure aws_ec2_local_gateway_virtual_interface_group(s) data source tags arguments work and are tested

Output from acceptance testing:

```
--- PASS: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_Filter (17.76s)
--- PASS: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_LocalGatewayId (17.68s)
--- PASS: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroup_Tags (21.87s)

--- PASS: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_basic (16.28s)
--- PASS: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_Filter (18.11s)
--- PASS: TestAccDataSourceAwsEc2LocalGatewayVirtualInterfaceGroups_Tags (22.15s)
```
@bflad
Copy link
Contributor Author

bflad commented Jun 16, 2020 •
edited
Loading

Support for new aws_ec2_local_gateway_virtual_interface_group and aws_ec2_local_gateway_virtual_interface_groups data sources have been merged and will release later this week with version 2.67.0 of the Terraform AWS Provider. 👍

@ghost
Copy link

ghost commented Jun 19, 2020

This has been released in version 2.67.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Jul 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bflad bflad

Labels
new-data-source Introduces a new data source. service/ec2 Issues and PRs that pertain to the ec2 service.
Projects
None yet
Milestone
v2.67.0
Development

Successfully merging a pull request may close this issue.

New Data Sources: aws_ec2_local_gateway_virtual_interface_group(s) hashicorp/terraform-provider-aws
1 participant
@bflad