Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_spot_fleet_request: gp3 volume scalable throughput #16652

Merged
merged 1 commit into from
Dec 11, 2020
Merged

aws_spot_fleet_request: gp3 volume scalable throughput #16652

merged 1 commit into from
Dec 11, 2020

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #16514.

Release note for CHANGELOG:

resource/aws_spot_fleet_request: Support `volume_type` value of `gp3`. Add `throughput` attribute to `launch_specification.ebs_block_device` and `launch_specification.root_block_device` configuration blocks.

Output from acceptance testing:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDeviceGp3\|TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDeviceGp3'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDeviceGp3\|TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDeviceGp3 -timeout 120m
=== RUN   TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDeviceGp3
=== PAUSE TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDeviceGp3
=== RUN   TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDeviceGp3
=== PAUSE TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDeviceGp3
=== CONT  TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDeviceGp3
=== CONT  TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDeviceGp3
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDeviceGp3 (124.58s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDeviceGp3 (124.82s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	124.908s

@ewbankkit
r/aws_spot_fleet_request: Add 'throughput' attribute to 'launch_speci…
7e4ea5c 
…fication.ebs_block_device' and 'launch_specification.root_block_device' configuration blocks.

Acceptance test output:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDeviceGp3\|TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDeviceGp3'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDeviceGp3\|TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDeviceGp3 -timeout 120m
=== RUN   TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDeviceGp3
=== PAUSE TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDeviceGp3
=== RUN   TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDeviceGp3
=== PAUSE TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDeviceGp3
=== CONT  TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDeviceGp3
=== CONT  TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDeviceGp3
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDeviceGp3 (124.58s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDeviceGp3 (124.82s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	124.908s
@ewbankkit ewbankkit requested a review from a team as a code owner December 8, 2020 22:35
@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 8, 2020
@ewbankkit ewbankkit mentioned this pull request Dec 8, 2020
Closed
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Dec 11, 2020
@bflad bflad self-assigned this Dec 11, 2020
@bflad bflad added this to the v3.21.0 milestone Dec 11, 2020
@bflad bflad mentioned this pull request Dec 11, 2020
Closed
bflad
bflad approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and merging since there are no regressions in GovCloud where its not working yet, thanks @ewbankkit 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSSpotFleetRequest_associatePublicIpAddress (130.57s)
--- PASS: TestAccAWSSpotFleetRequest_basic (140.75s)
--- PASS: TestAccAWSSpotFleetRequest_CapacityRebalance (129.49s)
--- PASS: TestAccAWSSpotFleetRequest_changePriceForcesNewRequest (260.05s)
--- PASS: TestAccAWSSpotFleetRequest_disappears (129.24s)
--- PASS: TestAccAWSSpotFleetRequest_diversifiedAllocation (150.49s)
--- PASS: TestAccAWSSpotFleetRequest_fleetType (130.17s)
--- PASS: TestAccAWSSpotFleetRequest_iamInstanceProfileArn (133.26s)
--- PASS: TestAccAWSSpotFleetRequest_instanceInterruptionBehavior (135.15s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDevice_KmsKeyId (143.39s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDeviceGp3 (140.86s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDevice_KmsKeyId (147.80s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDeviceGp3 (131.07s)
--- PASS: TestAccAWSSpotFleetRequest_launchSpecToLaunchTemplate (253.80s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplate (125.12s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplate_multiple (128.57s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplateToLaunchSpec (239.46s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplateWithOverrides (131.94s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzInGivenList (149.12s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzOrSubnetInRegion (141.20s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceSubnetInGivenList (177.65s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstancePools (149.81s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameAz (148.11s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameSubnet (188.78s)
--- PASS: TestAccAWSSpotFleetRequest_overriddingSpotPrice (147.84s)
--- PASS: TestAccAWSSpotFleetRequest_placementTenancyAndGroup (70.83s)
--- PASS: TestAccAWSSpotFleetRequest_tags (158.94s)
--- PASS: TestAccAWSSpotFleetRequest_updateExcessCapacityTerminationPolicy (258.17s)
--- PASS: TestAccAWSSpotFleetRequest_updateTargetCapacity (369.35s)
--- PASS: TestAccAWSSpotFleetRequest_withEBSDisk (140.94s)
--- PASS: TestAccAWSSpotFleetRequest_WithELBs (168.33s)
--- PASS: TestAccAWSSpotFleetRequest_withoutSpotPrice (147.62s)
--- PASS: TestAccAWSSpotFleetRequest_withTags (130.94s)
--- PASS: TestAccAWSSpotFleetRequest_WithTargetGroups (340.90s)
--- PASS: TestAccAWSSpotFleetRequest_withWeightedCapacity (199.22s)
--- PASS: TestAccAWSSpotFleetRequest_zero_capacity (189.92s)
--- SKIP: TestAccAWSSpotFleetRequest_WithInstanceStoreAmi (0.00s)

Output from acceptance testing in AWS GovCloud (US) (no regressions; created followup issue: #16722):

--- FAIL: TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDeviceGp3 (18.90s)
--- FAIL: TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDeviceGp3 (24.87s)
--- PASS: TestAccAWSSpotFleetRequest_associatePublicIpAddress (146.48s)
--- PASS: TestAccAWSSpotFleetRequest_basic (146.50s)
--- PASS: TestAccAWSSpotFleetRequest_CapacityRebalance (137.17s)
--- PASS: TestAccAWSSpotFleetRequest_changePriceForcesNewRequest (245.84s)
--- PASS: TestAccAWSSpotFleetRequest_disappears (121.79s)
--- PASS: TestAccAWSSpotFleetRequest_diversifiedAllocation (131.82s)
--- PASS: TestAccAWSSpotFleetRequest_fleetType (137.67s)
--- PASS: TestAccAWSSpotFleetRequest_iamInstanceProfileArn (146.59s)
--- PASS: TestAccAWSSpotFleetRequest_instanceInterruptionBehavior (146.44s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_EbsBlockDevice_KmsKeyId (131.66s)
--- PASS: TestAccAWSSpotFleetRequest_LaunchSpecification_RootBlockDevice_KmsKeyId (124.80s)
--- PASS: TestAccAWSSpotFleetRequest_launchSpecToLaunchTemplate (247.95s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplate (145.44s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplate_multiple (130.52s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplateToLaunchSpec (253.47s)
--- PASS: TestAccAWSSpotFleetRequest_launchTemplateWithOverrides (145.49s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzInGivenList (126.21s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceAzOrSubnetInRegion (129.08s)
--- PASS: TestAccAWSSpotFleetRequest_lowestPriceSubnetInGivenList (182.24s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstancePools (135.25s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameAz (130.44s)
--- PASS: TestAccAWSSpotFleetRequest_multipleInstanceTypesInSameSubnet (206.19s)
--- PASS: TestAccAWSSpotFleetRequest_overriddingSpotPrice (130.85s)
--- PASS: TestAccAWSSpotFleetRequest_placementTenancyAndGroup (71.62s)
--- PASS: TestAccAWSSpotFleetRequest_tags (175.70s)
--- PASS: TestAccAWSSpotFleetRequest_updateExcessCapacityTerminationPolicy (243.06s)
--- PASS: TestAccAWSSpotFleetRequest_updateTargetCapacity (354.51s)
--- PASS: TestAccAWSSpotFleetRequest_withEBSDisk (134.09s)
--- PASS: TestAccAWSSpotFleetRequest_WithELBs (179.55s)
--- PASS: TestAccAWSSpotFleetRequest_withoutSpotPrice (131.17s)
--- PASS: TestAccAWSSpotFleetRequest_withTags (143.14s)
--- PASS: TestAccAWSSpotFleetRequest_WithTargetGroups (308.34s)
--- PASS: TestAccAWSSpotFleetRequest_withWeightedCapacity (190.06s)
--- PASS: TestAccAWSSpotFleetRequest_zero_capacity (202.72s)
--- SKIP: TestAccAWSSpotFleetRequest_WithInstanceStoreAmi (0.00s)

@bflad bflad merged commit b5f64e1 into hashicorp:master Dec 11, 2020
bflad added a commit that referenced this pull request Dec 11, 2020
@bflad
Update CHANGELOG for #16652
ed411a5
@ewbankkit ewbankkit deleted the f-aws_spot_fleet_request-gp3-throughput branch December 11, 2020 16:50
@ghost
Copy link

ghost commented Dec 11, 2020

This has been released in version 3.21.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@jayzalowitz jayzalowitz mentioned this pull request Dec 14, 2020
Merged
1 task
@ghost
Copy link

ghost commented Jan 10, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ec2 Issues and PRs that pertain to the ec2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.21.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ewbankkit @bflad