[New Resource] Create delegation signer association resource

[seanseth7]

Description

Adds support for creating a Delegation Signer record in the parent DNS zone for domains registered with Route53

Relations

Closes #28749

References

https://docs.aws.amazon.com/Route53/latest/APIReference/API_domains_AssociateDelegationSignerToDomain.html
https://docs.aws.amazon.com/Route53/latest/APIReference/API_domains_DisassociateDelegationSignerFromDomain.html

Output from Acceptance Testing

% make testacc TESTS=TestAccRoute53DomainsDelegationSignerAssocation_basic PKG=route53domains
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53domains/... -v -count 1 -parallel 20 -run='TestAccRoute53DomainsDelegationSignerAssocation_basic'  -timeout 360m
=== RUN   TestAccRoute53DomainsDelegationSignerAssocation_basic
=== PAUSE TestAccRoute53DomainsDelegationSignerAssocation_basic
=== CONT  TestAccRoute53DomainsDelegationSignerAssocation_basic
--- PASS: TestAccRoute53DomainsDelegationSignerAssocation_basic (152.19s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53domains     155.255s

% make testacc TESTS=TestAccRoute53DomainsDelegationSignerAssocation_disappears PKG=route53domains
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/route53domains/... -v -count 1 -parallel 20 -run='TestAccRoute53DomainsDelegationSignerAssocation_disappears'  -timeout 360m
=== RUN   TestAccRoute53DomainsDelegationSignerAssocation_disappears
=== PAUSE TestAccRoute53DomainsDelegationSignerAssocation_disappears
=== CONT  TestAccRoute53DomainsDelegationSignerAssocation_disappears
--- PASS: TestAccRoute53DomainsDelegationSignerAssocation_disappears (138.80s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/route53domains     141.989s
...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Hey @seanseth7 👋 Thank you very much for your contribution! At times, our maintainers need to make direct edits to pull requests in order to help get it ready to be merged. Your current settings do not allow maintainers to make such edits. To help facilitate this, update your pull request to allow such edits as described in GitHub's Allowing changes to a pull request branch created from a fork documentation. (If you're using a fork owned by an organization, your organization may not allow you to change this setting. If that is the case, let us know.)

[github-actions]

Welcome @seanseth7 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[seanseth7]

Hey @ewbankkit ! I see that you've recently been reviewing the PRs in this repo, and I'm not sure if the maintainers got notified when I marked this ready for review, so just wanted to put this on your radar in case there was no notification. No rush. Thanks!

[seanseth7]

@justinretzolk Any chance that someone could review this soon since this has been open for a while? Apologies if you're not the correct person to ask. Please feel free to tag the relevant people if that's the case.

[ewbankkit]

@seanseth7 Thanks for the contribution 🎉 👏.
I have completed your work in #35487 in order to get this merged quickly.
The resource has been renamed to aws_route53domains_delegation_signer_record to better reflect the thing that the resource represents.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.