resource/aws_lb: Fix ELBv2 attributes on create #3854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appilon
changed the title
|
Nice catch, looks very good to me. |
tombuildsstuff
approved these changes
Mar 26, 2018
| @@ -707,7 +707,7 @@ func flattenAwsLbResource(d *schema.ResourceData, meta interface{}, lb *elbv2.Lo | |||
| protectionEnabled := (*attr.Value) == "true" | |||
| log.Printf("[DEBUG] Setting LB Deletion Protection Enabled: %t", protectionEnabled) | |||
| d.Set("enable_deletion_protection", protectionEnabled) | |||
| case "enable_http2": | |||
There was a problem hiding this comment.
is the old key still valid, or is this a bug?
aws/resource_aws_lb_test.go
Outdated
| if *attr.Value == value { | ||
| return nil | ||
| } else { | ||
| return fmt.Errorf(`LB attribute %s expected: "%s" actual: "%s"`, key, value, *attr.Value) |
There was a problem hiding this comment.
minor you can use %q rather than %s to do the same thing as "%s" :)
bflad
added
bug
add acceptance checks on attribute tests
|
This has been released in version 1.13.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3848
Load balancer attributes can only be added after creation with a Modify sdk call. Our Update function does not appear to detect the initial configuration with
HasChange, usingIsNewResource()appears to ensure on create the attributes are configured.Specific to HTTP2 our internal state would have been wrong as the attribute keystring was incorrect (used our variable name and not amazon's strange dot notation). Also I noticed the acceptance tests were only checking internal state, as a more explicit check we now read the alb attributes and check the returned value.
My first initial implementation of the acceptance check is very inefficient for aggregate tests that want to validate multiple attributes we are wasting time fetching and iterating over and over. If feedback from others supports it I contemplated an acceptance tests that accepts a map or list of expected values and can check all of them in one pass.
Tests: