Terraform crash while changing s3 bucket

[ghost]

This issue was originally opened by @davidcox67 as hashicorp/terraform#19463. It was migrated here as a result of the provider split. The original body of the issue is below.

---

Terraform v0.11.10

• provider.aws v1.46.0

provider "aws" {
region = "us-east-1"
}

variable "bucket" {
default = "???"
}

terraform {
backend "s3" {
bucket = "???"
key = "???"
region = "us-east-1"
}
}

resource "aws_s3_bucket" "bucket" {
bucket = "${var.bucket}"
acl = ""

versioning {
    enabled = true
}

lifecycle_rule {
    prefix  = "clean/"
    enabled = true

    noncurrent_version_expiration {
        days = 30
    }
}

replication_configuration {
    role = "???"

    rules {
        id     = "???"
        prefix = ""
        status = "Enabled"
        priority = "1"

        destination {
            bucket        = "arn:aws:s3:::???"
            # storage_class = "STANDARD"
        }
    }
}

}

resource "aws_s3_bucket_policy" "bucket" {
bucket = "${aws_s3_bucket.bucket.id}"

policy = <<POLICY
{
"Version": "2008-10-17",
"Id": "PolicyForCloudFrontPrivateContent",
"Statement": [{
"Sid":"1",
"Effect":"Allow",
"Principal":{
"AWS": "arn:aws:iam::cloudfront:user/CloudFront Origin Access Identity ???"
},
"Action": "s3:GetObject",
"Resource":"arn:aws:s3:::???/*"
}]
}
POLICY
}

crash.log

[ewbankkit]

From the crash log:

2018-11-26T08:35:43.425-0500 [DEBUG] plugin.terraform-provider-aws_v1.46.0_x4: 2018/11/26 08:35:43 [DEBUG] Waiting for state to become: [success]
2018-11-26T08:35:43.842-0500 [DEBUG] plugin.terraform-provider-aws_v1.46.0_x4: panic: interface conversion: interface {} is nil, not map[string]interface {}
2018-11-26T08:35:43.842-0500 [DEBUG] plugin.terraform-provider-aws_v1.46.0_x4: 
2018-11-26T08:35:43.842-0500 [DEBUG] plugin.terraform-provider-aws_v1.46.0_x4: goroutine 278 [running]:
2018-11-26T08:35:43.842-0500 [DEBUG] plugin.terraform-provider-aws_v1.46.0_x4: github.com/terraform-providers/terraform-provider-aws/aws.resourceAwsS3BucketReplicationConfigurationUpdate(0xc000aee7d8, 0xc000918850, 0x19, 0x1)
2018-11-26T08:35:43.842-0500 [DEBUG] plugin.terraform-provider-aws_v1.46.0_x4: 	/opt/teamcity-agent/work/5d79fe75d4460a2f/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_s3_bucket.go:1836 +0x1b7d
2018-11-26T08:35:43.842-0500 [DEBUG] plugin.terraform-provider-aws_v1.46.0_x4: github.com/terraform-providers/terraform-provider-aws/aws.resourceAwsS3BucketUpdate(0xc000918850, 0x2d139c0, 0xc0008b9b00, 0x24, 0x603e3e0)
2018-11-26T08:35:43.842-0500 [DEBUG] plugin.terraform-provider-aws_v1.46.0_x4: 	/opt/teamcity-agent/work/5d79fe75d4460a2f/src/github.com/terraform-providers/terraform-provider-aws/aws/resource_aws_s3_bucket.go:665 +0x4a2
2018-11-26T08:35:43.842-0500 [DEBUG] plugin.terraform-provider-aws_v1.46.0_x4: github.com/terraform-providers/terraform-provider-aws/vendor/github.com/hashicorp/terraform/helper/schema.(*Resource).Apply(0xc000814380, 0xc000522b90, 0xc00050c3c0, 0x2d139c0, 0xc0008b9b00, 0x40b801, 0xc0000a3b80, 0x4bfe7c)

This is the relevant code: https://github.com/terraform-providers/terraform-provider-aws/blob/v1.46.0/aws/resource_aws_s3_bucket.go#L1832-L1838

		if f, ok := rr["filter"].([]interface{}); ok && len(f) > 0 {
			// XML schema V2.
			rcRule.Priority = aws.Int64(int64(rr["priority"].(int)))
			rcRule.Filter = &s3.ReplicationRuleFilter{}
			filter := f[0].(map[string]interface{})
			tags := filter["tags"].(map[string]interface{})
			if len(tags) > 0 {

[ewbankkit]

@davidcox67 Do you have the HCL for the resource before the update (i.e. last known good configuration)? Thanks.

[bflad]

This looks very similar to #7427. @davidcox67 are you able to provide any additional information about how this occurred?

[bflad]

Best effort fix submitted due to lack of issue replication: #7887

[bflad]

The fix mentioned above has been merged and will release with version 2.2.0 of the Terraform AWS Provider, likely later today.

[bflad]

This has been released in version 2.2.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!